Skip to content

Adding Query by Ingestion date #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

daralynnrhode
Copy link
Contributor

@daralynnrhode daralynnrhode commented Mar 31, 2025

Adding Ingestion start and end date Params

Overview

Adding ingestion_start_date and ingestion_end_date to the imap-data-access API command line.
Waiting for the sds-data-manager side of the work to be merged and deployed first before I can fully test it.

New Dependencies

New Files

Deleted Files

Updated Files

  • tests/test_io.py
  • imap_data_access/cli.py
  • imap_data_access/io.py

Testing

@maxinelasp
Copy link
Contributor

I just heard from a member of the MAG team that he has been using this branch successfully. So... nice job! I know finals are still ongoing, but when you return to work afterwards, could we get this finished up so we can deploy it?

@daralynnrhode
Copy link
Contributor Author

pre-commit.ci autofix

@daralynnrhode daralynnrhode changed the title [WIP] Adding Query by Ingestion date Adding Query by Ingestion date May 13, 2025
@daralynnrhode daralynnrhode requested review from a team, bourque, sdhoyt, maxinelasp and anamanica and removed request for a team May 13, 2025 15:04
Copy link
Contributor

@maxinelasp maxinelasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for doing this!

Copy link
Contributor

@bourque bourque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work!

@daralynnrhode daralynnrhode merged commit ad0f931 into IMAP-Science-Operations-Center:main May 13, 2025
16 checks passed
@daralynnrhode daralynnrhode deleted the query_by_ingestion branch May 13, 2025 15:54
@bourque bourque added this to IMAP May 19, 2025
@bourque bourque added this to the May 2025 milestone May 19, 2025
@daralynnrhode daralynnrhode moved this to Done in IMAP May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants